[apparmor] [patch 1/5] put the gettext define in one place

[John Johansen]

On 08/06/2014 10:18 AM, Christian Boltz wrote:
> Hello,
> 
> Am Mittwoch, 6. August 2014 schrieb john.johansen at canonical.com:
>> Signed-off-by: John Johansen <john.johansen at canonical.com>
> 
>> --- 2.9-test.orig/parser/dbus.cc
>> +++ 2.9-test/parser/dbus.cc
>> @@ -30,8 +30,6 @@
>>  #include "parser_yacc.h"
>>  #include "dbus.h"
>>
>> -#define _(s) gettext(s)
> 
> Just curious - in most other files you also remove
>     #include <libintl.h>
> 
> Is it still needed here, or did you just forget to remove it?
> 

just missed them

>> --- 2.9-test.orig/parser/lib.c
>> +++ 2.9-test/parser/lib.c
>> @@ -24,7 +24,6 @@
>>  #include <stddef.h>
>>  #include <stdlib.h>
>>  #include <unistd.h>
>> -#define _(s) gettext(s)
> 
> Same question here.
> 
>> --- 2.9-test.orig/parser/parser_lex.l
>> +++ 2.9-test/parser/parser_lex.l
>> @@ -38,8 +38,6 @@
>>  #include <unordered_map>
>>  #include <string>
>>
>> -#define _(s) gettext(s)
> 
> And here.
> 
>> --- 2.9-test.orig/parser/parser_variable.c
>> +++ 2.9-test/parser/parser_variable.c
>> @@ -26,8 +26,6 @@
>>
>>  #include <string>
>>
>> -#define _(s) gettext(s)
> 
> And here.
> 
> Besides that, the patch looks like a good idea ;-)
> 
> 
> Regards,
> 
> Christian Boltz
>