[apparmor] [patch 06/26] Convert aare_rules into a class
John Johansen
john.johansen at canonical.com
Wed Apr 16 04:05:36 UTC 2014
On 04/15/2014 07:06 PM, Seth Arnold wrote:
> On Tue, Apr 15, 2014 at 10:22:13AM -0700, john.johansen at canonical.com wrote:
>> This cleans things up a bit and fixes a bug where not all rules are
>> getting properly counted so that the addition of policy_mediation
>> rules fails to generate the policy dfa in some cases.
>>
>> Because the policy dfa is being generated correctly now we need to
>> fix some tests to use the new -M flag to specify the expected features
>> set of the test.
>>
>> Signed-off-by: John Johansen <john.johansen at canonical.com>
>> Acked-by: Steve Beattie <steve at nxnw.org>
>
> Most of this looked very straightforward, but I lost track of the
> rule_count++ lines; I sort of expected to find a second instance of
> rule_count++ somewhere. Should I have expected this?
>
Nope. The actual counting changes a little but since we where only
using it to determine if there had been rules add this doesn't make
any difference. Now the rule_count tracks how many rules have been
added to the aarules. It still works for what we were using it for
and is cleaner
More information about the AppArmor
mailing list