[apparmor] [PATCH 1/5] parser: Add dbus eavesdrop permission support to apparmor_parser

[Tyler Hicks]

On 2013-11-20 18:18:42, Christian Boltz wrote:
> Hello,
> 
> Am Mittwoch, 20. November 2013 schrieb Tyler Hicks:
> > Also, note that all of those AA_MAY_* macros are simply defined above
> > using raw values. AA_MAY_WRITE is not tied in any way to the parser's
> > AA_MAY_WRITE in parser/immunix.h.
> 
> Did you just say that this code is calling for trouble? ;-)  [1]
> 
> It would be a good idea to have _one_ file with the definitions of 
> AA_MAY_WRITE etc., which is then used by everything that needs those 
> macros.

Right, that's what I was implying. I'll fix this in a bit.

Tyler

> 
> 
> Regards,
> 
> Christian Boltz
> 
> [1] code duplication is _always_ calling for trouble, and I doubt this 
>     macro definition is an exception ;-)
> -- 
> Ich Stecke eure Nasen _direkt_ in das Tulpenbeet und bekomme trotzdem
> noch solche Antworten. Und _Ihr_ wundert euch, dass ich inzwischen so
> schnell zynisch oder agressiv werde?    [Henning Hucke in suse-linux]
> 
> 
> -- 
> AppArmor mailing list
> AppArmor at lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20131120/55ceecce/attachment.pgp>