[apparmor] [PATCH 1/5] parser: Add dbus eavesdrop permission support to apparmor_parser

Christian Boltz apparmor at cboltz.de
Wed Nov 20 17:18:42 UTC 2013


Hello,

Am Mittwoch, 20. November 2013 schrieb Tyler Hicks:
> Also, note that all of those AA_MAY_* macros are simply defined above
> using raw values. AA_MAY_WRITE is not tied in any way to the parser's
> AA_MAY_WRITE in parser/immunix.h.

Did you just say that this code is calling for trouble? ;-)  [1]

It would be a good idea to have _one_ file with the definitions of 
AA_MAY_WRITE etc., which is then used by everything that needs those 
macros.


Regards,

Christian Boltz

[1] code duplication is _always_ calling for trouble, and I doubt this 
    macro definition is an exception ;-)
-- 
Ich Stecke eure Nasen _direkt_ in das Tulpenbeet und bekomme trotzdem
noch solche Antworten. Und _Ihr_ wundert euch, dass ich inzwischen so
schnell zynisch oder agressiv werde?    [Henning Hucke in suse-linux]




More information about the AppArmor mailing list