[apparmor] [PATCH 2/7] libapparmor: fix return value of aa_getpeercon_raw

Seth Arnold seth.arnold at canonical.com
Mon Jun 24 18:52:05 UTC 2013


On Sun, Jun 23, 2013 at 04:23:14PM -0700, Tyler Hicks wrote:
> From: John Johansen <john.johansen at canonical.com>
> 
> Return the total size of the security context on success
> as documented.
> 
> Signed-off-by: John Johansen <john.johansen at canonical.com>

The implementation of this idea is fine. But the *size parameter is
already being updated with the length, which seems sufficient to me.

Thanks

> ---
>  libraries/libapparmor/src/kernel_interface.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libraries/libapparmor/src/kernel_interface.c b/libraries/libapparmor/src/kernel_interface.c
> index 1c3b4df..ee7908a 100644
> --- a/libraries/libapparmor/src/kernel_interface.c
> +++ b/libraries/libapparmor/src/kernel_interface.c
> @@ -583,6 +583,8 @@ int aa_getpeercon_raw(int fd, char *buffer, int *size)
>  			optlen++;
>  		}
>  	}
> +
> +	rc = optlen;
>  out:
>  	*size = optlen;
>  	return rc;
> -- 
> 1.8.1.2
> 
> 
> -- 
> AppArmor mailing list
> AppArmor at lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20130624/dfcb15d6/attachment.pgp>


More information about the AppArmor mailing list