[apparmor] [PATCH] parser: Add DFA minimization equality tests for D-Bus rules

Christian Boltz apparmor at cboltz.de
Tue Dec 24 22:02:45 UTC 2013


Hello,

Am Dienstag, 24. Dezember 2013 schrieb Tyler Hicks:
> Tests should be added for other rule types but this is a good start at
> testing DFA minimization.

IIRC the original problem you discovered was with mount rules, so they 
would be a next good step ;-)

> Signed-off-by: Tyler Hicks <tyhicks at canonical.com>
> ---
>  parser/tst/equality.sh | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/parser/tst/equality.sh b/parser/tst/equality.sh
> index 7370c61..c022927 100755
> --- a/parser/tst/equality.sh
> +++ b/parser/tst/equality.sh

> +verify_binary_equality "dbus minimization with all perms" \
> +	"/t { dbus, }" \
> +	"/t { dbus bus=session, dbus, }" \
> +	"/t { dbus (send, receive, bind, eavesdrop), dbus, }"
[...]

Acked-By: Christian Boltz <apparmor at cboltz.de>


Regards,

Christian Boltz

PS: non-random sig ;-)
-- 
Get back there in front of the computer NOW. Christmas can wait.
[Linus "the Grinch" Torvalds, 24 Dec 2000 on linux-kernel]




More information about the AppArmor mailing list