[apparmor] [PATCH] add abstractions to support the apparmor api

[Kees Cook]

Hi John,

On Fri, Oct 19, 2012 at 12:05:09PM -0700, John Johansen wrote:
> Just a simple set of abstractions to support the base apparmor api
>
> Signed-off-by: John Johansen <john.johansen at canonical.com>

Looks good. Some cleanups, suggested below, and can you add final
newlines, where it has complained?

Otherwise:

Acked-by: Kees Cook <kees at ubuntu.com>

> --- /dev/null
> +++ b/profiles/apparmor.d/tunables/kernelvars
> [...]
> +# until kernel vars are implemented just use a pattern [0-9]{1,6}
> +@{pid}=[0-9]{[0-9]{[0-9]{[0-9]{[0-9]{[0-9],},},},},}

The first digit should not include the 0 in the set.

> --- /dev/null
> +++ b/profiles/apparmor.d/abstractions/apparmor_api/find_mountpoint
> [...]
> \ No newline at end of file

> --- /dev/null
> +++ b/profiles/apparmor.d/abstractions/apparmor_api/is_enabled
> [...]
> \ No newline at end of file

> --- /dev/null
> +++ b/profiles/apparmor.d/tunables/kernelvars
> [...]
> \ No newline at end of file

-Kees

--
Kees Cook