[apparmor] [PATCH 13/27] apparmor: move the free_profile fn ahead of aa_alloc_profile

[John Johansen]

On 11/21/2012 08:47 AM, Steve Beattie wrote:
> On Tue, Nov 20, 2012 at 08:39:53PM -0800, John Johansen wrote:
>> From: John Johansen <john.johansen at canonical.com>
>>
>> Move the free_profile fn ahead of aa_alloc_profile so it can be used
>> in aa_alloc_profile without a forward declaration.
>>
>> Signed-off-by: John Johansen <john.johansen at canonical.com>
> Acked-by: Steve Beattie <sbeattie at ubuntu.com>
> 
> While I don't have a problem with this code re-arrangement, I don't
> actually see where free_profile() gets used by aa_alloc_profile()
> or aa_new_null_profile() or anything that looked like a called macro
> function within them. Attempting to search later patches in the series
> didn't find anything that added it to those functions. Am I missing
> something?
>

yes, the rearrangement of the patches themselves (it used to be that
patch 20 did the dirname mangling in the alloc_profile fn and if it
failed would bail and call free_profile.  That changed but I left
the free_profile patch because of the many patches yet to follow.

>> ---
>>  security/apparmor/policy.c |  150 ++++++++++++++++++++++----------------------
>>  1 file changed, 75 insertions(+), 75 deletions(-)
>>
>> diff --git a/security/apparmor/policy.c b/security/apparmor/policy.c
>> index 13fc9ef..f4ee72b 100644
>> --- a/security/apparmor/policy.c
>> +++ b/security/apparmor/policy.c
> 
> 
>