[apparmor] [PATCH] towards a common build infrastructure

[Christian Boltz]

Hello,

Am Sonntag, 6. Mai 2012 schrieb Kees Cook:
> On Sun, May 06, 2012 at 01:46:30AM +0200, Christian Boltz wrote:
> > I prefer hand-written Makefiles - but that might be a matter of
> > personal taste ;-) (and, in my case, missing knownledge about
> > automake)
>
> I find it much easier to deal with large projects via autoconf and
> automake. There is rarely anything 'strange' enough that it requires
> much fiddling. I prefer it because it makes the build system familiar
> to most people trying to understand it, and the templates are small.

I'd guess even more people understand plain Makefiles ;-) and I can
guarantee you that nearly nobody understands the automake-generated
Makefiles (reading them might be needed to track down build issues)

> > > === modified file 'README'
> > 
> > You only deleted the lines describing the current build "system",
> > but
> > didn't add any note how to build AppArmor with automake...
> 
> It's still there. It's just hugely reduced. (Which is why I wanted to
> push for this.)

Re-reading your patch a second time, I noticed that you are right.
I expected some + lines in the README patch, but you found a clever way 
to recycle the existing lines ;-)

> I just want the build system simplified. 

Well, I remember (from another project) that plain Makefiles can work 
with subdirs without problems. Something like this will work as Makefile
in the top-level directory (untested braindump)


subdirs=changehat/mod_apparmor changehat/pam_apparmor libraries/libapparmor parser profiles utils

all:
	for dir in $(subdirs) ; do make -C $$dir || exit 1 ; done
clean:
	for dir in $(subdirs) ; do make -C $$dir clean || exit 1 ; done
install:
	for dir in $(subdirs) ; do make -C $$dir install || exit 1 ; done


And now tell me how automake can make things simpler than this ;-)

Hmm, I should have sent this as patch earlier - it would have been easier
than updating the spec with tons of "make -C" calls...


Regards,

Christian Boltz

[1] after dropping the laaaaarge automake patch
-- 
Eight Megabytes Always Continuously Swapping ;-)
[Paketbeschreibung für emacs in SuSE 8.2]