[apparmor] [PATCH] Fix hexdigit conversion in the pcre parser

[John Johansen]

On 02/23/2012 09:05 PM, Seth Arnold wrote:
> Little-used feature, huh? 
> 
yeah not commonly used, but uh needed now.

> Ack on all trees.
> ------Original Message------
> From: John Johansen
> Sender: apparmor-bounces at lists.ubuntu.com
> To: apparmor at lists.ubuntu.com
> Subject: [apparmor] [PATCH] Fix hexdigit conversion in the pcre parser
> Sent: Feb 23, 2012 8:56 PM
> 
> The pcre parser in the dfa backend is not correctly converting escaped
> hex string like
>   \0x0d
> 
> This is the minimal patch to fix, and we should investigate just using
> the C/C++ conversion routines here.
> 
> I also I nominated for the 2.7 series.
> 
> Signed-off-by: John Johansen <john.johansen at canonical.com>
> ---
>  parser/libapparmor_re/parse.y |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/parser/libapparmor_re/parse.y b/parser/libapparmor_re/parse.y
> index e2f3a81..d4d2159 100644
> --- a/parser/libapparmor_re/parse.y
> +++ b/parser/libapparmor_re/parse.y
> @@ -169,7 +169,7 @@ int hexdigit(char c)
>  	else if (c >= 'A' && c <= 'F')
>  		return 10 + c - 'A';
>  	else if (c >= 'a' && c <= 'f')
> -		return 10 + c - 'A';
> +		return 10 + c - 'a';
>  	else
>  		return -1;
>  }