[apparmor] [PATCH] Fix hexdigit conversion in the pcre parser

John Johansen john.johansen at canonical.com
Fri Feb 24 04:56:54 UTC 2012


The pcre parser in the dfa backend is not correctly converting escaped
hex string like
  \0x0d

This is the minimal patch to fix, and we should investigate just using
the C/C++ conversion routines here.

I also I nominated for the 2.7 series.

Signed-off-by: John Johansen <john.johansen at canonical.com>
---
 parser/libapparmor_re/parse.y |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/parser/libapparmor_re/parse.y b/parser/libapparmor_re/parse.y
index e2f3a81..d4d2159 100644
--- a/parser/libapparmor_re/parse.y
+++ b/parser/libapparmor_re/parse.y
@@ -169,7 +169,7 @@ int hexdigit(char c)
 	else if (c >= 'A' && c <= 'F')
 		return 10 + c - 'A';
 	else if (c >= 'a' && c <= 'f')
-		return 10 + c - 'A';
+		return 10 + c - 'a';
 	else
 		return -1;
 }
-- 
1.7.9




More information about the AppArmor mailing list