[apparmor] [PATCH 02/13] Convert FLAGS_MODE start condition to a generic list of values start cond

Kees Cook kees at ubuntu.com
Tue Feb 14 19:06:45 UTC 2012


Hi John,

On Tue, Feb 14, 2012 at 09:32:24AM -0800, John Johansen wrote:
> @@ -535,7 +532,7 @@ LT_EQUAL	<=
>  {OPEN_PAREN}	{
>  			DUMP_PREPROCESS;
>  			PDEBUG("FLag (\n");

Should this PDEBUG get changed to something more context-sensible? "Flag"
seems to make sense sense after this refactor.

Otherwise, it looks good to me.

-Kees

-- 
Kees Cook



More information about the AppArmor mailing list