[apparmor] aa-notify still broken :-(

[Christian Boltz]

Hello,

Am Samstag, 24. September 2011 schrieb Jamie Strandboge:
> On Sat, 2011-09-24 at 13:52 +0200, Christian Boltz wrote:
> > OK, I commited the HOME part and a TODO note about $DISPLAY.
> 
> I didn't get a chance to comment on this. Setting DISPLAY to the
> default of ':0' feels wrong to me too. 

I know, but...

> I don't have an alternative at this time.

This describes the problem very well ;-)

> As for HOME, I think putting it in send_message is the wrong place.
> While it is guaranteed to always be up to date, I don't think that
> people are changing their HOME all that often and I think all the
> hits on an LDAP database for each message is too much. I think that
> something like the attached patch (against current trunk) would be
> better (untested).

Good point, I fully agree.

I just verified that the value of $notify_home is set correctly, 
therefore I'd say the patch is OK.

Note: If we decide to use the :0 fallback for $DISPLAY, the 
implementation that sets $notify_display will need to make sure that it 
is only set if $DISPLAY was not set before.
If we add a commandline option, it should of course override $DISPLAY.


Regards,

Christian Boltz
-- 
Man taucht nicht auf einer Mailingliste auf, schreibt technisch grotten-
kaputte Mails. Und wenn einem das versehentlich passiert und man sich
dafür einen berechtigten Anschiss abholt, stellt man sich nicht noch auf
die Apfelsinenkiste und hält Plädoyers über Humor und freie Meinungs-
äußerung - dann schraubt man an seinen knatternden Mailclient gefälligst
den Auspuff wieder an und ist lieb. [Ratti in suse-linux]