[apparmor] [patch] apparmor-utils: Add support for creds and path operations (apparmor-utils-add-log-types)

John Johansen john.johansen at canonical.com
Mon Aug 22 22:27:48 UTC 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/22/2011 02:52 PM, Steve Beattie wrote:
> On Thu, Aug 18, 2011 at 03:50:35PM -0700, John Johansen wrote:
>> --- utils/Immunix/AppArmor.pm	2011-08-17 23:26:41 +0000
>> +++ utils/Immunix/AppArmor.pm	2011-08-18 22:49:58 +0000
>> @@ -2861,7 +2861,8 @@
>>               $e->{operation} eq "truncate" ||
>>               $e->{operation} eq "mkdir" ||
>>               $e->{operation} eq "rename_src" ||
>> -             $e->{operation} eq "rename_dest") {
>> +             $e->{operation} eq "rename_dest" ||
>> +             $e->{operation} =~ m/^(unlink|rmdir|symlink_create|link)$/) {
>>          add_to_tree( $e->{pid},
>>  		     $e->{parent},
>>                       "path",
>>
>> NAK, and an ACK for the slightly revised patch (attached).  Basically
>> several of the operation where already in AppArmor.pm upstream so I
>> removed those ones from the list
> 
> One of the concerns I had when I briefly looked at this patch was
> whether the added operation included new or different tags (name2)
> that the particular if-statement didn't yet handle, but I never had
> time to track down if this was the case.
> 
It does not, that is something that needs to get added
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk5S19wACgkQxAVxIsEKI+Y1FgCfdVdGBzobOkWaeRWXx3yVxjgG
A/4AoICiZh1ejmp3LL7893hd+27pHoQt
=n0pX
-----END PGP SIGNATURE-----



More information about the AppArmor mailing list