[apparmor] parser line number reporting
John Johansen
john.johansen at canonical.com
Fri Jun 25 17:13:22 BST 2010
On 06/25/2010 04:09 AM, Steve Beattie wrote:
> On Fri, Jun 25, 2010 at 04:05:44AM -0700, Steve Beattie wrote:
>> On Mon, Jun 21, 2010 at 01:32:54PM -0700, Kees Cook wrote:
>>> Nominations from me:
>>>
>>> r1413 (correct line number and filename tracking for error messages)
>>
>> I don't think this should be accepted without the additional attached
>> patch, as there are some subtle errors in the line counting happening.
>> See the attached patch's description.
>
> Haha, I shouldn't try to write patches late at night. Really
> attaching the patch this time.
>
>> It's submitted for review for both trunk and for 2.5.1 as a condition
>> for acceptance of r1413.
>>
>> (As an aside, Kees, I'm glad you added testcases with the lineno
>> commit, though the infrastructure needs to be improved to make adding
>> additional testcases easier.)
>
>
looks good thanks steve
ack
More information about the AppArmor
mailing list