[apparmor] [PATCH] Fix expr tree node labeling

[Steve Beattie]

On Wed, Jul 07, 2010 at 11:16:25AM -0700, John Johansen wrote:
> On 07/07/2010 10:58 AM, John Johansen wrote:
> > expression tree node labeling is used during debugging dumps.  Currently the node labels
> > are computed and stored in a map, that is not cleaned up.  This means that the labeling
> > is retained across different dfas.
> > 
> > Move the labeling into expr node as this takes less memory than using a map and will
> > also separates node labeling so its per dfa instead of global.  In addition this means
> > the labeling is cleanedup/freed when the expr tree is freed without any extra work.
> > 
> I would like to nominate this patch for 2.5.1 as it reduces peak memory usage, especially
> for profiles with lots of hats as the labeling map grows with each hat added.

Merged after review into the 2.5.1 nominations branch. Thanks John!

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/apparmor/attachments/20100712/4ebeb946/attachment.pgp