<div class="gmail_quote"><div>Hi All! Thank you for the review! I pushed the changes that you requested.</div><div class="im"><div class="gmail_quote"><br></div><div class="gmail_quote">2012/9/3 Bhavani Shankar R <span dir="ltr"><<a href="mailto:bhavi@ubuntu.com" target="_blank">bhavi@ubuntu.com</a>></span></div> </div><div class="gmail_quote"><div class="im"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> - The docs, Readme.Debian and Readme.Source files have no reasonable<br> content as of now and can be removed I guess </blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> - The /source directory is empty as of now. You can consider creating<br> a format file inside that and adding 3.0 (native) to it<br> - The source link and the Upstream-Contact field in d/copyright file is missing<br> (You might want to consider updating to<br> <a href="http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/" target="_blank">http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/</a>)</blockquote></div><div>All done. </div><div class="im"><div> <br></div><div><br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> - The desktop file doesnt seem to work with me as yet </blockquote></div><div>The way I've written the program, the desktop file will either cause OrthCal's</div><div>indicator to be launched or, if it's already in the indicator area, it will cause</div> <div>OrthCal to launch, showing the daily feasts in the New Calendar.</div><div><br></div><div>I guess that created the confusion. I could have the desktop file launch both</div><div>the indicator and the main program if you would like.</div> <div class="im"> <div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">and lintian<br> throws out the following warning:<br> W: orthcal: desktop-command-not-in-package<br> usr/share/applications/extras-orthcal.desktop perl </blockquote></div><div>For some reason, the Exec part of the desktop file has to be </div><div>"/usr/bin/perl /opt/<a href="http://extras.ubuntu.com/orthcal/bin/OrthCal.pl" target="_blank">extras.ubuntu.com/orthcal/bin/OrthCal.pl</a>"</div> <div>in order for the launcher to start OrthCal.</div><div><br></div><div>Removing 'perl' and listing only the script's location disables the launcher, even</div><div>if the script has a correct Perl shebang and runs just fine from terminal. I am</div> <div>clueless as to why that happens. Please, tell me how I could change the desktop</div><div>file and have the launcher work at the same time.</div><div class="im"><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> - There are three binary files generated in the package:<br> -rwxr-xr-x root/root 99 2012-09-03 20:08 ./usr/bin/OrthCal and<br> -rwxr-xr-x root/root 28911 2012-09-03 20:08<br> ./opt/<a href="http://extras.ubuntu.com/orthcal/bin/OrthCal.pl" target="_blank">extras.ubuntu.com/orthcal/bin/OrthCal.pl</a><br> and -rwxr-xr-x root/root 5175 2012-09-03 20:08<br> ./opt/<a href="http://extras.ubuntu.com/orthcal/bin/OrthCal_ind.py" target="_blank">extras.ubuntu.com/orthcal/bin/OrthCal_ind.py</a><br> Kindly request your explanation on the same.<br></blockquote></div><div>The binary file with a location of /usr/bin/OrthCal is redundant and I removed it.</div><div>Its only purpose was so that OrthCal could be launched from terminal, just by</div> <div>typing 'OrthCal'.<br><br></div><div>As to OrthCal_ind.py, its only purpose is to create an indicator for the program,<br>whereas the main functionality comes from OrthCal.pl. At the time when I was<br>first writing the program, Perl did not have appindicator bindings and I had to<br> resort to Python to create an indicator for my app. Starting with Quantal,</div><div>Perl appindicator bindings are available through the libgtk2-appindicator-perl<br>package. Should I target quantal and remove the Python script right now? </div> <div class="im"> <div> </div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> As a side note: The saints.db file is good :) (If you had got this<br> from somewhere it is advisable to mention their name in a file called<br> CONTRIBUTORS in the src package and a mention in d/copyright)</blockquote></div><div>The db file contains entries for daily feasts from two websites currently.</div><div>Orthodoxwiki.org -for english content- and <a href="http://saint.gr" target="_blank">saint.gr</a> -for greek content. I wrote</div> <div>myself a script to extract the information from these two sources.<br><br></div><div>The first source offers all content under a CC BY-SA 2.5 license.<br><br></div><div>Saint.gr on the other hand does not offer a specific license. Rather, they mention</div> <div>"freely ye have received, freely give" in Greek, explaining that anyone can use the<br>content for any purpose, even without citing its source.<br><br>I am citing both these sources in the about section of OrthCal. How can I refer to</div> <div><a href="http://saint.gr" target="_blank">saint.gr</a>'s license in debian/copyright? Also, how do I explain about the db having<br>content coming under two different licenses? In the future, more languages might</div> <div>be added, leading to perhaps other licenses as well.</div> <div><br></div><div>Thanks in advance.</div><div>Dimitrios</div></div></div>