<div>Hi,
</div><div><br></div><div>Does config.rb need a license? It's just a file that contains options to compile scss - it can be safely deleted. It's under the BSD license anyway.</div><div><br></div><div>To close the settings, just click outside the settings window and it will close.</div><div><br></div><div>Thanks,</div><div>Jono</div>
<div></div>
<p style="color: #A0A0A8;">On Monday, 6 August 2012 at 5:57 AM, Bhavani Shankar R wrote:</p>
<blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;">
<span><div><div><div>On Sat, Aug 4, 2012 at 12:17 PM, Bhavani Shankar R <<a href="mailto:bhavi@ubuntu.com">bhavi@ubuntu.com</a>> wrote:</div><blockquote type="cite"><div><div>On Thu, Aug 2, 2012 at 5:00 PM, Jono Cooper <<a href="mailto:jono@jonocooper.com">jono@jonocooper.com</a>> wrote:</div><blockquote type="cite"><div><div>Yep, issues are fixed.</div><div><br></div><div>Cheers</div></div></blockquote><div><br></div><div>Just pulled in the latest branch</div><div><br></div><div>App working for me here now wrt sync and refresh.</div><div><br></div><div>But havent had a look at the packaging yet</div><div><br></div><div>So m reserving my vote for now</div><div><br></div><div>Regards,</div></div></blockquote><div><br></div><div>Packaging looks generally good except:</div><div><br></div><div>lightread/data/media/app/config.rb doesnt specify a license (although</div><div>in d/copyright its mentioned that all files are in bsd 3)</div><div><br></div><div>Lintian reports warning wrt d/copyright</div><div><br></div><div>W: lightread source: syntax-error-in-dep5-copyright line 8: Duplicate</div><div>field copyright.</div><div><br></div><div>the runtime.d/ directory was found to be empty</div><div><br></div><div>drwxr-xr-x root/root 0 2012-08-05 23:08 ./usr/share/python/runtime.d/</div><div><br></div><div>(It just stores *.rtupdate file(s) and can be removed I guess)</div><div><br></div><div>stopping review here.</div><div><br></div><div>As a side note: ran the app clicked on settings and found no way there</div><div>to close the settings window on my system. Am I missing something</div><div>here?</div><div><br></div><div>I would like to still keep my +0 here</div><div><br></div><div>Regards,</div><div><br></div><div>-</div><div><br></div><div>-- </div><div>Bhavani Shankar</div><div>Ubuntu Developer | <a href="http://www.ubuntu.com">www.ubuntu.com</a></div><div><a href="https://launchpad.net/~bhavi">https://launchpad.net/~bhavi</a></div></div></div></span>
</blockquote>
<div>
<br>
</div>