Review: Password generator and memorizer

Bhavani Shankar R bhavi at ubuntu.com
Sun Sep 16 12:38:48 UTC 2012


Dear All,

(cc'ing the app author too)

Below is a quick review on password generator and memorizer package
from the developer PPA:

- I didnt build the package though but looking at the rules file I
dont see a rule which has /opt stuff with required programs/icons etc
in it.
- I think the program uses pwqgen and pwgen to generate passwords
(relevant bits can be mentioned in d/copyright with the credits I
think)
- The standards version in d/control is a bit outdated (3.8.3 v/s 3.9.3)
- The short description and long description in d/control is missing
- Package has a dependency on cdbs (if not used, it can be removed)
- debhelper version in d/control and d/compat doesnt match (6 v/s 8)
- d/copyright contains invalid copyright URL specification. Instead it
can be updated to match
http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
- d/copyright contains some cruft  like Copyright: (C) 2012 Bryan
Quigley</property> which can be removed

-1 here until above are fixed.

-- 
Bhavani Shankar
Ubuntu Developer       |  www.ubuntu.com
https://launchpad.net/~bhavi



More information about the App-review-board mailing list