[Vote] Cuckoo Alarm

John Vrbanac john.vrbanac at linux.com
Mon Sep 10 14:08:19 UTC 2012


Thank you Bhavani!

- John Vrbanac



On 09/10/2012 02:06 AM, Bhavani Shankar R wrote:
> On Thu, Jul 19, 2012 at 1:39 PM, Andrew Mitchell <ajmitch at ubuntu.com> wrote:
>> On Tue, Jul 10, 2012 at 12:04:11PM -0400, Jonathan Carter (highvoltage) wrote:
>>> On 2012-07-10 10:04, Stéphane Graber wrote:
>>>> Same comment as with FlashGen:
>>>> /opt/extras.ubuntu.com/cuckoo/cuckoo/indicator.py shouldn't have a
>>>> shebang as it's not an executable script (just meant to be imported)
>>>>
>>>> That's minor and the rest looks good here: +1
>>>>
>>>> (As with all the others, I just did static analysis of the source and
>>>> binary, haven't actually installed or run it)
>>> Same, +1 from me otherwise.
>>>
>>> -Jonathan
>> +1
>>
>> Andrew
>>
>
> Built, Installed, Tested with alarm.ogg (which seems the default file)
> and uploaded to extras PPA
>
> Regards,
>
>




More information about the App-review-board mailing list