[Vote] Modem Manager GUI

[Bhavani Shankar R]

On Sun, Sep 9, 2012 at 5:06 PM, Bhavani Shankar R <bhavi at ubuntu.com> wrote:
> On Mon, Aug 20, 2012 at 7:47 PM, Bhavani Shankar R <bhavi at ubuntu.com> wrote:
>> On Mon, Aug 13, 2012 at 2:04 PM, Andrew Mitchell <ajmitch at ubuntu.com> wrote:
>>> On Wed, Jul 18, 2012 at 05:42:25PM -0400, Jonathan Carter (highvoltage) wrote:
>>>> On 2012-07-16 16:24, Michael Hall wrote:
>>>> >I have reviewed this app and made some changes to fix lintian and
>>>> >arb-lint warnings.
>>>> >
>>>> >The code with changes is here:
>>>> >
>>>> >https://code.launchpad.net/~mhall119/ubuntu-app-reviews/modem-manager-gui/
>>>>
>>>> It doesn't seem to access any system files in any way or do anything
>>>> weird that escalates to root, packaging also looks good.
>>>>
>>>> +1
>>>>
>>>> -Jonathan
>>>
>>> +1, though I did switch it back to 3.0 (native) for it to build.
>>>
>>> Andrew
>>>
>>
>> +1 to Andrew's comment. Apart from that I found the AUTHORS file
>> missing from the source and couple of minor lintian warnings:
>>
>> W: modem-manager-gui: possible-unindented-list-in-extended-description
>> I: modem-manager-gui: capitalization-error-in-description dbus D-Bus
>>
>> These should be straightforward to fix, So +1
>>
>
>
> Pulled in the latest version from developers' PPA. Fixed the above
> except the lintian warning (as it can be ignored I think) and uploaded
> to extras PPA for some basic testing.
>

Oops!

s/extras/staging

Regards
-- 
Bhavani Shankar
Ubuntu Developer       |  www.ubuntu.com
https://launchpad.net/~bhavi