Review: OrthCal

[Bhavani Shankar R]

Hi All

I just took a quick look at OrthCal from the developer's PPA here:

https://launchpad.net/~dgkontopoulos/+archive/orthcal/+packages

Few Observations:

- The docs, Readme.Debian and Readme.Source files have no reasonable
content as of now and can be removed I guess
- The /source directory is empty as of now. You can consider creating
a format file inside that and adding 3.0 (native) to it
- The source link and the Upstream-Contact field in d/copyright file is missing
(You might want to consider updating to
http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/)
- The desktop file doesnt seem to work with me as yet and lintian
throws out the following warning:
W: orthcal: desktop-command-not-in-package
usr/share/applications/extras-orthcal.desktop perl
- There are three binary files generated in the package:
-rwxr-xr-x root/root        99 2012-09-03 20:08 ./usr/bin/OrthCal and
-rwxr-xr-x root/root     28911 2012-09-03 20:08
./opt/extras.ubuntu.com/orthcal/bin/OrthCal.pl
and -rwxr-xr-x root/root      5175 2012-09-03 20:08
./opt/extras.ubuntu.com/orthcal/bin/OrthCal_ind.py
Kindly request your explanation on the same.

As a side note: The saints.db file is good :) (If you had got this
from somewhere it is advisable to mention their name in a file called
CONTRIBUTORS in the src package and a mention in d/copyright)

+0 for now

Regards,



-- 
Bhavani Shankar
Ubuntu Developer       |  www.ubuntu.com
https://launchpad.net/~bhavi