A lot of time

[Bhavani Shankar R]

On Wed, Oct 3, 2012 at 8:55 PM, Bhavani Shankar R <bhavi at ubuntu.com> wrote:
> On Wed, Oct 3, 2012 at 7:25 PM, Adrián Arroyo Calle
> <adrian.arroyocalle at gmail.com> wrote:
>> Hi, I upload to Azpazeta PPA, the new version of Azpazeta. In the others
>> apps I'm working but I don't have much time, so I will upload the others
>> apps in other month. The new Azpazeta version solves the RPATH problems.
>> Thanks for the atention.
>
> Thanks Adrian!
>
> Will take a look first up tomorrow morning
>
> Thanks for your work and patience!
>

Hello Adrian,

Here goes a more detailed review: (Although not comprehensive as I
havent test built the app yet)

1. The size of the program looks big and I saw a lot of files present
in the source dir

bhavani at bhavani-spagetti-monster:~/azapetta/azpazeta-1.0.0.4$ find .
-type f | wc -l
129

(AFAICS ARB only reviews lightweight apps)

(In which case you can be better off going through the ubuntu sponsors
queue next cycle to get your package into ubuntu I guess (Since we are
past feature freeze there now) This link will give you more info
https://wiki.ubuntu.com/SponsorshipProcess

2. In the source folder, found a lot of executable jpg files, a .bin
file and lot of src files with the azpazeta src bundled in a zip file
there which makes it bit difficult for us to review

3. multiplayer folder too contained some considerable amount of source
files with txt files.Kindly explain as to what the files in these two
directories do

4. Coming to the packaging, below are my observations:

a) When I ran licensecheck on the source files I found the output as
"No copyright" *UNKNOWN* but your d/copyright states that the source
is in gpl v3. You might want to update the license headers of src
files.

b) The short description in d/control is the package name and could be
reworded as to what the game is all about and how it functions. Same
goes with the long description I believe

c) Standards Version in d/control could be bumped to reflect the
latest one i.e 3.9.3

d) d/copyright could be updated to reflect the latest standards.
Please refer http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
for more info

As a  side note: The license on the portal shows its MIT and
d/copyright says its in gpl v3 which is conflicting.

Stopping review here.

Regards,

-- 
Bhavani Shankar
Ubuntu Developer       |  www.ubuntu.com
https://launchpad.net/~bhavi