Lintian checking ARB packages

[Bhavani Shankar R]

On Mon, Nov 19, 2012 at 8:57 PM, Daniel Holbach
<daniel.holbach at ubuntu.com> wrote:
> Hello everybody,
>
> you all remember the times when we needed a tool to check the ARB
> packages and needed it quickly. Everybody knew back then that the checks
> would be much more appropriate in lintian and I felt dirty putting
> something together very quickly. It did its job, but it wasn't very nice
> and of course it should've been part of lintian in the first place.
>
> Niels, the maintainer of lintian, approached me at UDS to talk about
> this. He was very kind enough not to murder me on the spot and even
> kinder than that: please see the attached email he sent - he implemented
> most of our tests in lintian itself. Thanks so much for your hard work
> Niels (CCed), this is great.
>
> Every member of https://launchpad.net/~ubuntu-app-review-contributors
> should be able to upload an updated lintian to
> https://launchpad.net/~ubuntu-app-review-contributors/+archive/ppa - we
> would just need to update the instructions on the AppReviewBoard wiki
> pages for this.
>
> Once we have the new lintian in place, I'm happy for lp:arb-lint to go
> away. :)
>
> Thanks again, Niels. This is great news.
>

Hi Daniel,

whilst applying first patch works since its only a profile inclusion.
Applying 2nd patch causes FTBFS of run tests.

Running source-copyright-dep5-general 1.0... building... testing... ok.
Running source-copyright-dep5-syntax-error 1.0... building... testing... ok.
Running source-copyright-missing 1.0... building... testing... ok.
Running source-copyright-ood-uri 1.0... building... testing... ok.
Running source-copyright-symlink 1.0... building... testing... ok.
Running source-copyright-unknown-uri 1.0... building... testing... ok.
Running source-copyright-unversioned-uri 1.0... building... testing... ok.
Running source-copyright-wiki-uri 1.0... building... testing... ok.
Running spelling-general 1.0... building... testing... ok.
Running spelling-multiword 1.0... building... testing... ok.
Running spelling-package-name 1.0... building... testing... ok.
Running standards-version-invalid 1.0... building... testing... ok.
Running standards-version-newer 1.0... building... testing... ok.
Running standards-version-old 1.0... building... testing... ok.
Running standards-version-timewarp 1.0... building... testing... ok.
Running standards-version-timewarp-unrel 1.0... building... testing... ok.
Running symlinks-broken 1.0... building... testing... ok.
Running watch-file-general 2.0.ds1-1... building... testing... ok.
Running version-substvars-general 1.0... building... testing... ok.
Running watch-file-native 1.0... building... testing... ok.
Running watch-file-no-version 1.0-1... building... testing... ok.
Running watch-file-old-upstream-version 2.0-1... building... testing... ok.
Running watch-file-prerelease 1~rc1-1... building... testing... ok.
Running watch-file-should-mangle 1+dfsg-1... building... testing... ok.
Running watch-file-template 1.0-1... building... testing... ok.
Running generic-dh-make-2005 1-1... building... testing... ok.
Running generic-dh-make-2008 1.0-1... building... testing... ok.
Running generic-empty 1.0... building... testing... ok.
make: *** [runtests] Error 1
dpkg-buildpackage: error: debian/rules build gave error exit status 2
E: Failed autobuilding of package
I: unmounting /var/cache/pbuilder/ccache filesystem
I: unmounting dev/pts filesystem
I: unmounting proc filesystem
I: cleaning the build env
I: removing directory /var/cache/pbuilder/build//12980 and its subdirectories

and before that I find this:

===(     481;8  15/?  0/?
)=============================================Unknown check
(ubuntu/arb/arb-check-bin) in arb-app.profile.
# Looks like your test exited with 255 before it could output anything.
t/scripts/profiles-coverage.t ............................. Dubious,
test returned 255 (wstat 65280, 0xff00)
Failed 965/965 subtests
t/scripts/static-lab.t .................................... ok
t/scripts/strict.t ........................................ ok
t/scripts/tags.t .......................................... ok
t/scripts/unpack-level.t .................................. ok
t/scripts/version.t ....................................... ok
t/scripts/minimum-version.t ............................... ok

Test Summary Report
-------------------
t/scripts/profiles-coverage.t                           (Wstat: 65280
Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 965 tests but ran 0.
Files=47, Tests=10394, 27 wallclock secs ( 1.86 usr  0.16 sys + 34.67
cusr  1.24 csys = 37.93 CPU)
Result: FAIL


Attached is the diff (Manually applied patches byhand and tested)

Niels: Thanks for the patch. Please correct me if I am wrong somewhere.

Regards,

-- 
Bhavani Shankar
Ubuntu Developer       |  www.ubuntu.com
https://launchpad.net/~bhavi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lintian-arb.diff
Type: application/octet-stream
Size: 6149 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/app-review-board/attachments/20121120/2e3ec05e/attachment.obj>