[vote] unity-lens-vm

Andrew Mitchell ajmitch at ubuntu.com
Tue Jun 19 10:30:22 UTC 2012


On Mon, Jun 18, 2012 at 09:39:50AM +0200, Daniel Holbach wrote:
> Hello,
> 
> On 14.06.2012 05:43, Andrew Mitchell wrote:
> > I checked over the vm lens, but the first thing that I spotted after building
> > was that there are several files outside of /opt which aren't namespaced:
> > Directories like /usr/share/unity/lenses/vm/ should instead be
> > /usr/share/unity/lenses/extra-unity-lens-vm/ and the D-BUS service file 
> > should be ./usr/share/dbus-1/services/extras-unity-lens-vm.service
> > Small things, but they're needed to make sure there's no file conflicts.
> 
> with some help of Michael Hall and David Callé the issues might now be
> fixed. Can anyone give
> 
>   lp:~dholbach/ubuntu-app-reviews/vm-lens
> 
> another look please?
> 
> Have a great day,
>  Daniel
> 
I've taken a look at the updated branch & it looks good now, +1 from me.

Andrew



More information about the App-review-board mailing list