[vote] unity-lens-vm

Andrew Mitchell ajmitch at ubuntu.com
Thu Jun 14 03:43:30 UTC 2012

On Tue, Jun 12, 2012 at 02:03:30PM -0400, Jonathan Carter (highvoltage) wrote:
> Hi
> https://myapps.developer.ubuntu.com/dev/apps/807
> Daniel made some fixes to the quickly-generated package and posted it at:
> lp:~dholbach/ubuntu-app-reviews/vm-lens
> I had a look over it and everything looks fine so I'm putting it to vote.
> +1 from me.
> -Jonathan

>From my comments on IRC:

I checked over the vm lens, but the first thing that I spotted after building
was that there are several files outside of /opt which aren't namespaced:
Directories like /usr/share/unity/lenses/vm/ should instead be
/usr/share/unity/lenses/extra-unity-lens-vm/ and the D-BUS service file 
should be ./usr/share/dbus-1/services/extras-unity-lens-vm.service
Small things, but they're needed to make sure there's no file conflicts.


More information about the App-review-board mailing list