[Vote] FlashBox

[Bhavani Shankar R]

On Mon, Jul 23, 2012 at 11:56 PM, John Vrbanac <john.vrbanac at linux.com> wrote:
> I have reviewed this app. The only change I needed to make was collapsing
> the changelog down to one entry.
>
> The code with my change is located here:
> https://code.launchpad.net/~john.vrbanac/ubuntu-app-reviews/flashbox

Dear John,

Thanks a lot for your work.

- found that licensecheck says that some files are in public domain

bhavani at bhavani-spagetti-monster:~/arb$ licensecheck -r --copyright flashbox
flashbox/setup.py: GPL (v3,)
  [Copyright: 2012 Javed Khan <tuxcanfly at gmail.com>]

flashbox/flashcache.py: *No copyright* UNKNOWN

flashbox/flashbox_lib/PreferencesDialog.py: *No copyright* Public domain

flashbox/flashbox_lib/Builder.py: *No copyright* Public domain

flashbox/flashbox_lib/helpers.py: *No copyright* Public domain

flashbox/flashbox_lib/flashboxconfig.py: *No copyright* Public domain

flashbox/flashbox_lib/AboutDialog.py: *No copyright* Public domain

flashbox/flashbox_lib/__init__.py: *No copyright* Public domain

flashbox/flashbox_lib/Window.py: *No copyright* Public domain

flashbox/tests/test_lint.py: *No copyright* Public domain

flashbox/tests/test_example.py: *No copyright* Public domain

flashbox/flashbox/FlashboxWindow.py: GPL (v3,)
  [Copyright: 2012 Javed Khan <tuxcanfly at gmail.com>]

flashbox/flashbox/PreferencesFlashboxDialog.py: *No copyright* Public domain

flashbox/flashbox/AboutFlashboxDialog.py: *No copyright* Public domain

flashbox/flashbox/__init__.py: *No copyright* Public domain

whereas d/copyright says that files are released under gpl-3:

Files: *
Copyright: (C) 2012 Javed Khan <tuxcanfly at gmail.com>
License: GPL-3

Also found the short description was equal to the long description in
d/control which can be reworded better to be more descriptive I guess
based on functionality of the app

Stopped the review here.

>
> I installed the app and it appeared to function with vimeo; however, I
> didn't test it past that.

Installed the app as a part of app showdown and found it just pops up
a window with status as ready and a link to a video on vimeo and I
couldnt get to know how the app functions. Would like a simple
help/demo integrated into the app to have an overview of the app
functionality I think personally.

> I believe this app is ready for a vote.

Abstaining for now. +0 here.

Regards,
-- 
Bhavani Shankar
Ubuntu Developer       |  www.ubuntu.com
https://launchpad.net/~bhavi