[Vote] GTumbler

Bhavani Shankar R bhavi at ubuntu.com
Sun Jul 22 16:40:50 UTC 2012


On Sat, Jul 21, 2012 at 8:47 PM, Michael Hall <mhall119 at ubuntu.com> wrote:
> I found the relevant license file at
> https://raw.github.com/mfenniak/pyPdf/trunk/LICENSE
>
> I included that text in the debian/copyright file for those files that
> use it.  Rev 28 of my branch.
>

Hi Michael,

Thanks for your work. I just had a look at Rev 28. Most of them looks good

A few doubts below

- Still the debian/control debhelper compatibility doesn't match debian/compat
- Still the XB- tags are present.

licensecheck shows the below warnings:

gtumbler/gtumbler_lib/pdf/__init__.py: *No copyright* UNKNOWN
gtumbler/gtumbler_lib/pdf/xmp.py: *No copyright* UNKNOWN
gtumbler/gtumbler_lib/command.py: *No copyright* UNKNOWN

A conditional +1 based on my doubts above get cleared

Regards,



-- 
Bhavani Shankar
Ubuntu Developer       |  www.ubuntu.com
https://launchpad.net/~bhavi



More information about the App-review-board mailing list