[Vote] Fogger

[Owas Lone]

On Sat, Jul 21, 2012 at 8:02 PM, Stéphane Graber <stgraber at ubuntu.com> wrote:
> On 07/19/2012 12:57 AM, Owas Lone wrote:
>> On Thu, Jul 19, 2012 at 4:19 AM, Jonathan Carter (highvoltage)
>> <jonathan at ubuntu.com> wrote:
>>> On 2012-07-18 18:32, Michael Hall wrote:
>>>>
>>>> Depends on what it exposes, the Unity, Indicator and Notification APIs
>>>> only really give you access to things you've already send them anyway.
>>>
>>>
>>> Indeed, that's why I think someone should look at it, to determine what
>>> exactly it exposes and to which extent.
>>>
>>> -Jonathan
>>>
>>>
>>> --
>>> App-review-board mailing list
>>> App-review-board at lists.ubuntu.com
>>> Modify settings or unsubscribe at:
>>> https://lists.ubuntu.com/mailman/listinfo/app-review-board
>>
>> Hi,
>>
>> I've fixed the copyright file and updated the arb-review branch
>> (lp:~loneowais/fogger/arb-review).
>>
>> The JS API exposed the following desktop features to web apps,
>>
>>     * Unity Launcher Entry   -  Just then entry for itself. Not
>> possible to acess up entries for other apps.
>>     * App menu and HUD - Again, limited to itself
>>     * Notifications
>>     * No read or write access is allowed to any app. Apps cannot
>> read/write anything from the system.
>>
>> If you want to review the API bits, checkout
>>
>>     * fogger_lib/Bridge.py
>>     * data/js/fogger.js
>>
>> I'd like to publish the latest version from the ppa
>> (ppa:loneowais/fogger) built from quickly trunk
>> (lp:~loneowais/fogger/quickly_trunk) which is kept in sync with trunk
>> (lp:fogger) so you might want to review that as that's what I want to
>> be published to USC.
>>
>> Thanks a lot!
>
>  - Missing copyright in fogger_lib/FogApp.py
>  - debian/copyright lists code as GPL-3+ but in-code copyright is GPL-3
>  - debian/copyright lists Canonical and Rosetta contributors but no
> matching copyright header can be found in the code. If it only applies
> to translations, use a separate section, clearly stating the license.
>
> Stopping review at this point, -1 for now.
>
>
> --
> Stéphane Graber
> Ubuntu developer
> http://www.ubuntu.com
>
>
> --
> App-review-board mailing list
> App-review-board at lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/app-review-board
>

Fixed and pushed to  lp:~loneowais/fogger/arb-review


-- 
Owais Lone
hello at owaislone.org
http://www.owaislone.org