[Vote] Full Circle Bookshelf

[Stéphane Graber]

On 07/14/2012 10:20 AM, Charles Chan wrote:
> Patched local branch to prompt the user when opening an issue in the
> browser.
> https://code.launchpad.net/~charles-wh-chan/+archive/ppa/fullcircle-bookshelf

What local branch? you're just linking to a PPA...


> Please review again.
> 
> On Fri, Jul 13, 2012 at 7:37 AM, Charles Chan <charles.wh.chan at gmail.com
> <mailto:charles.wh.chan at gmail.com>> wrote:
> 
>     Thank you for your feedback, I will add a confirmation dialogue
>     prior to opening in the browser.
> 
>     I have the other ideas in mind as well, but want to evolve the app
>     gradually.
> 
> 
>     On Thursday, July 12, 2012, Bhavani Shankar R wrote:
> 
>         On Thu, Jul 12, 2012 at 3:28 PM, Daniel Holbach
>         <daniel.holbach at ubuntu.com> wrote:
>         > On 12.07.2012 11:45, Andrew Mitchell wrote:
>         >> On Tue, Jul 10, 2012 at 03:50:49PM -0400, Michael Hall wrote:
>         >>> I have reviewed this app and made a few changes to fix
>         lintian and
>         >>> arb-lint warnings.  The code can is here:
>         >>>
>         >>>
>         https://code.launchpad.net/~mhall119/ubuntu-app-reviews/fullcircle-bookshelf/
>         >>>
>         >>> This app is ready for a vote.
>         >>
>         >> This appears to need a build-dependency on libglib2.0-bin, as
>         it failed to
>         >> build in a chroot without it.
>         >
>         > Done in lp:~dholbach/ubuntu-app-reviews/fullcircle-bookshelf and
>         > uploaded to the ARB helpers PPA, so it's easier to review for
>         the judges.
>         >
> 
>         Packaging seems good, Built fine with libglib2.0-bin, Installs neat.
> 
>         Coming to the app running part:
> 
>         At first I thought it was a browser which enables us to browse full
>         circle magazine in a window looking at the description instead a
>         window opened with small cover of fcm in a window (which didnt
>         enlarge
>         while maximised) and I kept hitting left and right and tapping the
>         cover thinking that nothing is happening then I opened up my browser
>         to see it connected to the url of a particular issue of fcm. Would
>         really like a dialogue/message saying like connecting to fcm
>         issue xx
>         through your browser when we tap on a particular issue cover to
>         avoid
>         confusion.
> 
>         Put it short m abstaining here. +0 for now.
> 
>         Regards
> 
> 
>         --
>         Bhavani Shankar
>         Ubuntu Developer       |  www.ubuntu.com <http://www.ubuntu.com>
>         https://launchpad.net/~bhavi
> 
> 
> 


-- 
Stéphane

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/app-review-board/attachments/20120721/1c5deda6/attachment.pgp>