[Vote] F5 Notifier

[Stéphane Graber]

On 07/13/2012 03:24 AM, David Planella wrote:
> Forwarding Nathan's e-mail to the ARB list, which is where reviews happen.
> 
> Thanks a lot for reviewing the app!
> 
> Cheers,
> David.
> 
> -------- Missatge original --------
> Assumpte: 	[Vote] F5 Notifier
> Data: 	Thu, 12 Jul 2012 19:46:33 -0700
> De: 	Nathan Osman
> A: 	ubuntu-app-devel
> CC: 	georgeyk.dev
> 
> 
> 
> I have reviewed F5 Notifer according to the instructions on this page
> <https://wiki.ubuntu.com/AppReviewBoard/Review/Showdown>. There were a
> couple of very minor Lintian warnings and arb-lint produced a warning
> and error <http://dpaste.com/770046/> that I was able to correct. I have
> created a branch (lp:~george-edison55/ubuntu-
> <goog_1105631132>app-reviews/f5-notifier
> <https://code.launchpad.net/%7Egeorge-edison55/ubuntu-app-reviews/f5-notifier>)
> that addresses all of the issues I encountered. For some reason,
> debian/rules had the wrong filename on lines 22 and 24 (I removed the
> 'extras-' prefix because it is added when the file is moved to
> /usr/share/applications).
> 
> I have also tested the application to ensure that it functions as described.
> 
> - Nathan

- debian/copyright is invalid. It lists the code as GPL-3 but the
in-code copyright shows GPL-3+.

Stopping the review there, will do another full review once fixed.
-1 for now.

-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/app-review-board/attachments/20120721/6bdb8980/attachment.pgp>