[Vote] Blubphone

[Stéphane Graber]

On 07/21/2012 10:04 AM, Markus Lanner wrote:
> Hi
> 
> Thx for testing ur app!
> 
> I already got informed about that issue 2days and 15hours ago; 10 hours
> later I pushed a new version which fixed it?
> 
> Because I don't know bazaar or launchpad very well, I did a new clone:
> bzr branch lp:~markus-lanner/blubphone/quickly_trunk
> 
> "bzr log" got me
> committer: Markus Lanner <markus at mlanner.com>
> branch nick: blubphone
> timestamp: Mon 2012-07-09 16:12:29 +0200
> 
> The cloned src is up-to-date with fixed years. I commited my
> "fixed-year" version 2 days ago successfully with "quickly submitubuntu".
> 
> So, have I done something wrong? did I push to the wrong repo? or
> violate any rule?
> 
> Have fun
> Markus

Sorry, didn't know that another branch existed.

Any reason why you didn't base your branch on Daniel's?

I don't have an easy way of going through the last few changes, so I'll
need to take some more time to review from scratch later.

Until then I'm converting my -1 to a +0 so that other board members can
do the review in my place.


> 
> On 21/07/12 15:48, Stéphane Graber wrote:
>> On 07/13/2012 12:13 PM, Daniel Holbach wrote:
>>> Hello everybody,
>>>
>>> I reviewed and tested Blubphone and with a couple of changes, which can
>>> be found in
>>>
>>>  lp:~dholbach/ubuntu-app-reviews/blubphone
>>>
>>> the app is ready for vote.
>>>
>>> Please review and vote.
>>>
>>> Have a great day,
>>>  Daniel
>>  - All source files have an invalid copyright (YYYY).
>>
>> ./tests/test_example.py: GPL (v3,)
>>   [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
>> Weilharter caitilyn at gmail.com]
>>
>> ./tests/test_lint.py: GPL (v3,)
>>   [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
>> Weilharter caitilyn at gmail.com]
>>
>> ./setup.py: GPL (v3,)
>>   [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
>> Weilharter caitilyn at gmail.com]
>>
>> ./blubphone_lib/helpers.py: GPL (v3,)
>>   [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
>> Weilharter caitilyn at gmail.com]
>>
>> ./blubphone_lib/__init__.py: GPL (v3,)
>>   [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
>> Weilharter caitilyn at gmail.com]
>>
>> ./blubphone_lib/blubphoneconfig.py: GPL (v3,)
>>   [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
>> Weilharter caitilyn at gmail.com]
>>
>> ./blubphone_lib/AboutDialog.py: GPL (v3,)
>>   [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
>> Weilharter caitilyn at gmail.com]
>>
>> ./blubphone_lib/Builder.py: GPL (v3,)
>>   [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
>> Weilharter caitilyn at gmail.com]
>>
>> ./blubphone_lib/Window.py: GPL (v3,)
>>   [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
>> Weilharter caitilyn at gmail.com]
>>
>> ./blubphone_lib/PreferencesDialog.py: GPL (v3,)
>>   [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
>> Weilharter caitilyn at gmail.com]
>>
>> ./blubphone/Message.py: GPL (v3,)
>>   [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
>> Weilharter caitilyn at gmail.com]
>>
>> ./blubphone/__init__.py: GPL (v3,)
>>   [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
>> Weilharter caitilyn at gmail.com]
>>
>> ./blubphone/Write.py: GPL (v3,)
>>   [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
>> Weilharter caitilyn at gmail.com]
>>
>> ./blubphone/Network.py: GPL (v3,)
>>   [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
>> Weilharter caitilyn at gmail.com]
>>
>> ./blubphone/AboutBlubphoneDialog.py: GPL (v3,)
>>   [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
>> Weilharter caitilyn at gmail.com]
>>
>> ./blubphone/PreferencesBlubphoneDialog.py: GPL (v3,)
>>   [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
>> Weilharter caitilyn at gmail.com]
>>
>> ./blubphone/Status.py: GPL (v3,)
>>   [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
>> Weilharter caitilyn at gmail.com]
>>
>> ./blubphone/BlubphoneWindow.py: GPL (v3,)
>>   [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
>> Weilharter caitilyn at gmail.com]
>>
>> ./blubphone/SmsThread.py: GPL (v3,)
>>   [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
>> Weilharter caitilyn at gmail.com]
>>
>> ./blubphone/Contact.py: GPL (v3,)
>>   [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
>> Weilharter caitilyn at gmail.com]
>>
>> ./blubphone/Search.py: GPL (v3,)
>>   [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
>> Weilharter caitilyn at gmail.com]
>>
>>
>> Stopping review at this point, I'll want to do another full review once
>> those are fixed. -1
>>
> 


-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/app-review-board/attachments/20120721/4b653cfd/attachment.pgp>