[Vote] Alg3py

Bhavani Shankar R bhavi at ubuntu.com
Sat Jul 21 14:04:21 UTC 2012


On Sat, Jul 21, 2012 at 7:25 PM, Stéphane Graber <stgraber at ubuntu.com> wrote:
> On 07/21/2012 09:41 AM, Michael Hall wrote:
>> The submitter didn't provide any other name than jorgealda.
>>
>> I expanded the description using the information given to MyApps.  New
>> code is at rev 47 of my branch.
>>
>> Michael Hall
>> mhall119 at ubuntu.com
>
> That's incorrect, if you check debian/copyright you'll see:
> Jorge Alda jorgealda115 at gmail.com
>
> I expect debian/changelog to match that.

+1

>
>> On 07/21/2012 09:29 AM, Stéphane Graber wrote:
>>> On 07/18/2012 09:41 AM, Michael Hall wrote:
>>>> I have reviewed this app and made a few changes to fix lintian and
>>>> arb-lint warnings.
>>>>
>>>> The code with changes is here:
>>>> https://code.launchpad.net/~mhall119/ubuntu-app-reviews/alg3py/
>>>>
>>>> This app is ready for a vote.
>>>
>>>
>>>  - Wrong last name in debian/changelog
>>>  - Will need to change the version before upload
>>>  - Description is too short

Still the short description could be worded better I guess something
like "linear algebra computation tool" maybe

>>>
>>> Rest looks good, so conditional +1 on these being fixed.
>>>
>

Same with me too. Conditional +1 based on above points.


Regards




-- 
Bhavani Shankar
Ubuntu Developer       |  www.ubuntu.com
https://launchpad.net/~bhavi



More information about the App-review-board mailing list