[vote] Circle

[Stéphane Graber]

On 07/11/2012 05:08 PM, Andrew Starr-Bochicchio wrote:
> Hi,
> 
> I've reviewed Circle
> <https://myapps.developer.ubuntu.com/dev/apps/1237/>, and think it is
> ready for vote. I've pushed some minor packaging changes to:
> lp:~andrewsomething/ubuntu-app-reviews/circle  With these changes it
> is lintian clean except for the file installed to opt/ warning. It is
> also arb-lint clean. It builds in a clean precise chroot. I've
> installed it and gave it a quick test drive with no major issue.
> 
> Like for a previous app, my one other comment is that bin/circle is a
> bit on the generic side, but I suppose that's why we have the extras
> namespace. I'll leave it to the board to decide if that's a blocker.
> 
> Thanks,
> 
> -- Andrew Starr-Bochicchio
> 
>    Ubuntu Developer <https://launchpad.net/~andrewsomething>
>    Debian Maintainer
> <http://qa.debian.org/developer.php?login=a.starr.b%40gmail.com>
>    PGP/GPG Key ID: D53FDCB1

 - Version number will need to be updated prior to upload.
 - Missing lastname or firstname of copyright holder.
   - All source files
   - debian/control
   - debian/changelog
   - debian/copyright

Rest looks reasonable but I want to do another copyright review once
these are fixed. -1 for now.

-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/app-review-board/attachments/20120721/682a2a07/attachment-0001.pgp>