[Vote] Blubphone

Stéphane Graber stgraber at ubuntu.com
Sat Jul 21 13:48:30 UTC 2012


On 07/13/2012 12:13 PM, Daniel Holbach wrote:
> Hello everybody,
> 
> I reviewed and tested Blubphone and with a couple of changes, which can
> be found in
> 
>  lp:~dholbach/ubuntu-app-reviews/blubphone
> 
> the app is ready for vote.
> 
> Please review and vote.
> 
> Have a great day,
>  Daniel

 - All source files have an invalid copyright (YYYY).

./tests/test_example.py: GPL (v3,)
  [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
Weilharter caitilyn at gmail.com]

./tests/test_lint.py: GPL (v3,)
  [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
Weilharter caitilyn at gmail.com]

./setup.py: GPL (v3,)
  [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
Weilharter caitilyn at gmail.com]

./blubphone_lib/helpers.py: GPL (v3,)
  [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
Weilharter caitilyn at gmail.com]

./blubphone_lib/__init__.py: GPL (v3,)
  [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
Weilharter caitilyn at gmail.com]

./blubphone_lib/blubphoneconfig.py: GPL (v3,)
  [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
Weilharter caitilyn at gmail.com]

./blubphone_lib/AboutDialog.py: GPL (v3,)
  [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
Weilharter caitilyn at gmail.com]

./blubphone_lib/Builder.py: GPL (v3,)
  [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
Weilharter caitilyn at gmail.com]

./blubphone_lib/Window.py: GPL (v3,)
  [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
Weilharter caitilyn at gmail.com]

./blubphone_lib/PreferencesDialog.py: GPL (v3,)
  [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
Weilharter caitilyn at gmail.com]

./blubphone/Message.py: GPL (v3,)
  [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
Weilharter caitilyn at gmail.com]

./blubphone/__init__.py: GPL (v3,)
  [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
Weilharter caitilyn at gmail.com]

./blubphone/Write.py: GPL (v3,)
  [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
Weilharter caitilyn at gmail.com]

./blubphone/Network.py: GPL (v3,)
  [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
Weilharter caitilyn at gmail.com]

./blubphone/AboutBlubphoneDialog.py: GPL (v3,)
  [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
Weilharter caitilyn at gmail.com]

./blubphone/PreferencesBlubphoneDialog.py: GPL (v3,)
  [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
Weilharter caitilyn at gmail.com]

./blubphone/Status.py: GPL (v3,)
  [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
Weilharter caitilyn at gmail.com]

./blubphone/BlubphoneWindow.py: GPL (v3,)
  [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
Weilharter caitilyn at gmail.com]

./blubphone/SmsThread.py: GPL (v3,)
  [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
Weilharter caitilyn at gmail.com]

./blubphone/Contact.py: GPL (v3,)
  [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
Weilharter caitilyn at gmail.com]

./blubphone/Search.py: GPL (v3,)
  [Copyright: YYYY Markus Lanner markus at mlanner.com / YYYY Manuela
Weilharter caitilyn at gmail.com]


Stopping review at this point, I'll want to do another full review once
those are fixed. -1

-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/app-review-board/attachments/20120721/850977ff/attachment.pgp>


More information about the App-review-board mailing list