Review: Snare

Gregory Bonik gregory at
Thu Jul 12 18:27:20 UTC 2012


I'm not sure whether I'm supposed to reply to this message, but anyway:

* I don't understand what the note about the downloading of the orig tar
means. The package has been built cleanly in my ppa
* Yes, I forgot to include the copyright header in src/format.h. Should
I really fix it?
* About the lint error: this is rather a bug in arb-lint. I need to
install the file type associations for my program, so I have to install
them to standard directory /ust/share/mime. I have added the extras-
prefix to avoid any name clashes.

Thank you,
Gregory Bonik.

On 07/12/2012 09:24 PM, Martin Owens wrote:
> Review Done:
> App:
> Branch: lp:~ubuntu-app-review-contributors/ubuntu-app-reviews/snare
> Note: Build process is traditional using Quilt 3, required the
> downloading of the orig tar for 0.9.1:
> and naming correctly.
> License Check: GPLv3 or later, two missing files:
> src/format.h: *No copyright* UNKNOWN
> src/format.h: *No copyright* UNKNOWN
> Functionality Check: All Working (12.04)
> Lint Results:
> E: These files are outside opt/ and shouldn't be:
>    - usr/share/mime/packages/extras-snare.xml

More information about the App-review-board mailing list