Review: timecontrol

Martin Owens doctormo at gmail.com
Thu Jul 12 16:53:41 UTC 2012


Review Done:

App: https://myapps.developer.ubuntu.com/dev/apps/1283/
Branch:lp:~ubuntu-app-review-contributors/ubuntu-app-reviews/timecontrol

License Check: GPLv3, all correct

Functionality Check: All Working (12.04)

Lint Results:

W: The ARB wants only one changelog entry in debian/changelog, so you
might
   want to collate all the relevant information in one changelog entry
   under the last version and date.
W: This app seems to list cdbs as a Build-Depends in debian/control, but
   does not use it in debian/rules. It should be safe to remove it in
   debian/control.
W: You might want to update the Standards-Version in debian/control to
   version 3.9.3.
W: This app might be too big to be reviewed by the ARB. It has 47 source
   files and 7303 lines of code. This might serve as reply to the app
   submitter: We are sorry to inform you that this app is outside the
scope
   of the App Review Board. Our focus is on lightweight apps. We are
   generally looking for the kind of apps which could be reviewed for
   functionality and security in about an hour reading through the code.
   https://wiki.ubuntu.com/UbuntuDevelopment/NewPackages might suit you
   better.
W: This package does not use DEP-5, which provides a machine-readable
   debian/copyright file. You might want to review
   http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ to
   find out how to accomplish it. http://bazaar.launchpad.net/~dholbach
   /ubuntu-app-reviews/harvestwidget/view/head:/debian/copyright has a
live
   example for a simple app.





More information about the App-review-board mailing list