[Vote] Temperature Converter

Jonathan Carter (highvoltage) jonathan at ubuntu.com
Thu Jul 12 16:55:41 UTC 2012


Hi Andrew

On 2012-07-10 20:45, Andrew Starr-Bochicchio wrote:
> I've reviewed Temperature Converter

Thanks!

> <https://myapps.developer.ubuntu.com/dev/apps/1184/>, and think it is
> ready for vote. I've pushed some minor packaging changes to:
> lp:~andrewsomething/ubuntu-app-reviews/temperature-converter  With
> these changes it is lintian clean except for the file installed to
> opt/ warning. It is also arb-lint clean. It builds in a clean precise
> chroot. I've installed it and gave it a quick test drive with no 
> major
> issue.
>
> My one other comment is that bin/temperature-converter is a bit on 
> the
> generic side, but I suppose that's why we have the extras namespace.
> I'll leave it to the board to decide if that's a blocker.

Heh, indeed. What's bin/temperature-converterc? Running file on it says 
it's python bytecode. If it's required, shouldn't it be built some time 
during package build time?

-Jonathan



More information about the App-review-board mailing list