stgraber at ubuntu.com
Tue Jul 10 15:31:51 UTC 2012
On 07/10/2012 09:59 AM, Stéphane Graber wrote:
> On 07/10/2012 04:27 AM, Daniel Holbach wrote:
>> Hello everybody,
>> I had a quick look over flashgen and to me it looks ready to go. Here's
>> a branch with some (very small) changes:
>> Have a great day,
> 13:55 < stgraber> dholbach: for flashgen, only "issue" I found is that
> /opt/extras.ubuntu.com/flashgen/flashgen_lib/edict.py shouldn't have a
> shebang as it's not an executable
> script (just meant to be imported)
> Would be great to encourage these developers to not include the shebang
> for non-executable files, it's the second app I spotted with that
> mistake, so I'm wondering if maybe it's a quickly bug?
> Anyway, won't block the vote on that. +1
Withdrawing that +1 until debian/copyright is a valid DEP5 copyright
file (including valid link to the specification).
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 900 bytes
Desc: OpenPGP digital signature
More information about the App-review-board