[vote] Cuttlefish

[Stéphane Graber]

On 07/10/2012 10:26 AM, Stéphane Graber wrote:
> On 07/10/2012 07:03 AM, Paolo Rotolo wrote:
>> Hi,
>> Stephane, thanks for your corrections.
>> I've re-uploaded the fixes in the branch:
>> https://code.launchpad.net/~paolorotolo/ubuntu-app-reviews/cuttlefisht
>>
>> Regards,
>> Paolo
> 
> W: cuttlefish: script-not-executable
> opt/extras.ubuntu.com/cuttlefish/cuttlefish/indicator.py
> 
> ^ that's the usual, "file contains shebang but isn't meant to be an
> executable" error, so ideally this file should be kept non-executable
> but the shebang removed from its header.
> 
> 
> As for the other ones I voted on, this isn't critical, so +1 regardless.

Withdrawing that +1 until debian/copyright is a valid DEP5 copyright
file (including valid link to the specification).



-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/app-review-board/attachments/20120710/e0283349/attachment.pgp>