[vote] Cuttlefish

[Stéphane Graber]

On 07/09/2012 01:10 PM, Stéphane Graber wrote:
> On 07/09/2012 12:31 PM, Paolo Rotolo wrote:
>> Hi all!
>> I did a review of Cuttlefish and I have updated the changes on a branch:
>> https://code.launchpad.net/~paolorotolo/ubuntu-app-reviews/cuttlefish
>> <https://code.launchpad.net/%7Epaolorotolo/ubuntu-app-reviews/cuttlefish>
>>
>> It is ready for me :)
>>
>> Regards,
>> Paolo
> 
> W: cuttlefish source: unused-build-dependency-on-cdbs
> W: cuttlefish source: package-needs-versioned-debhelper-build-depends 8
> W: cuttlefish source: debhelper-overrides-need-versioned-build-depends
> (>= 7.0.50~)
> W: cuttlefish source: ancient-standards-version 3.8.3 (current is 3.9.3)
> 
> The short-description and description could use some rewording, it's
> quite difficult to know what that app is supposed to do.
> 
> The binary package contains: python/runtime.d/
> The directory is empty but it still shouldn't be there.

For that specific point (runtime.d), we agreed that this file can now be
shipped in the package, so removing the rm call should fix the issue.
(The rational being that dh generate a file based on the binary package
name, so is inherently namespaced and won't conflict).

> 
> cuttlefish/indicator.py looks like an executable ("#!/usr/bin/python")
> but isn't marked as executable. I believe the problem here (detected by
> lintian) is that it shouldn't contain the shebang.
> 
> 
> None of these are critical but I'd prefer to have these fixed before voting.


-- 
Stéphane



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/app-review-board/attachments/20120709/3875654f/attachment-0001.pgp>