[reviews] Guallet
Allison Randal
allison at lohutok.net
Tue Feb 14 01:38:05 UTC 2012
This app required changes for installation in /opt, and to switch from
the deprecated python-support to dh_python2. Also a few other small
fixes for the DEP5 syntax and lintian errors (grammar/spelling in the
description).
One content mistake: on most screens he's using translated strings
appropriately, but on the window viewing past transactions, he's got the
text all hardcoded in Spanish. The currency symbol is also hardcoded to
the Euro on all screens. Should we require him to fix this before
launching in Extras, or suggest he change it in the next release?
Otherwise, the package is ready to go, available for review in the
staging PPA, and in the branch:
http://bazaar.launchpad.net/~allison/+junk/extras-guallet
(He also had build artifacts checked into the source repository, which I
removed. So, if you do a straight diff from my first check-in, you'll
get extraneous changes. The relevant changes start around revision 24.)
Allison
More information about the App-review-board
mailing list