[reviews] Framingham Calculator

[Stéphane Graber]

On 02/09/2012 05:21 PM, Allison Randal wrote:
> On 02/09/2012 01:35 AM, Allison Randal wrote:
>> I updated the .desktop file with appropriate paths for the executable
>> and icon image. I've had trouble before with the Dash and Launcher not
>> picking up icons that are installed in /opt, and seem to be having the
>> same problem here.
>
> Working like a charm now.
>
>> I'm stuck on one last thing, and that is that Quickly isn't finding the
>> Glade UI files in
>> /opt/extras.ubuntu.com/framimgham-1.0/share/framimgham/ui/... I've even
>> gone to the extreme of patching 'get_data_path' in
>> framingham_lib/framimghamconfig.py, and it still won't load them. I'll
>> pick it up tomorrow, but CC'ing mvo, since he's done some recent work on
>> the Quickly code for Precise, and may have ideas.
>
> Okay, got this working. It did require a small patch to setup.py for the
> data path, but tolerably non-disruptive.
>
> So, Framingham Calculator is ready to go. I'll let the developer know
> the tweaks it needed.
>
> Allison
>

Binary package looks good.
A few things that should be changed before upload:
  - Fleshing out the changelog a bit? Ideally with whatever ARB-specific 
changes were needed and give credit to the developer if they gave the 
initial packaging (not sure in this case).
  - The icon override in debian/rules seems to be missing, you need 
something like this to make the app show up in SC until the SRU is 
published:
override_dh_gencontrol:
»···dh_gencontrol
»···cp unity-lens-askubuntu.png ../unity-lens-askubuntu.png
»···dpkg-distaddfile unity-lens-askubuntu.png raw-meta-data -

I didn't try the app myself but I'm giving it a +1 once these few 
changes are made.

Thanks

-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com