[reviews] Framingham Calculator

Allison Randal allison at lohutok.net
Thu Feb 9 09:35:10 UTC 2012


This is a simple Quickly app, which has many advantages for code review.

One disadvantage of Quickly is that the Oneiric version uses the
deprecated python-support package. We talked about what to do with these
in the ARB meeting in November, and decided to manually update the apps
before publishing them. So, I updated the debian/control and
debian/rules file to use dh_python2 instead. (The changes are only a few
lines.)

I also updated the debian/copyright file to list the Quickly copyright
(Rick Spencer and Dider Roche is what's listed in Quickly's copyright
file) for the boilerplate libraries that every Quickly app includes.
This seems like the best approach, but I'm open to other suggestions.

I updated the debhelper version and debian/compat to 8, and updated
Standards-Version to 3.9.2.

I updated the .desktop file with appropriate paths for the executable
and icon image. I've had trouble before with the Dash and Launcher not
picking up icons that are installed in /opt, and seem to be having the
same problem here. Installing the icons in the paths
/usr/share/icons/hicolor/16x16/apps/<appname>.png and similar works
fine. Has anyone else had better success with icons in /opt?

I used --install-lib, --install-scripts, and --install-data on an
override of dh_auto_install to change the install paths to
/opt/extras.ubuntu.com/framingham-0.1/...

I also used an override on dh_install to manually add the 'extras-'
prefix to the .desktop file, and copy it to the standard
usr/share/applications directory.


I'm stuck on one last thing, and that is that Quickly isn't finding the
Glade UI files in
/opt/extras.ubuntu.com/framimgham-1.0/share/framimgham/ui/... I've even
gone to the extreme of patching 'get_data_path' in
framingham_lib/framimghamconfig.py, and it still won't load them. I'll
pick it up tomorrow, but CC'ing mvo, since he's done some recent work on
the Quickly code for Precise, and may have ideas.

Allison



More information about the App-review-board mailing list