[Vote] Ridual
Bhavani Shankar R
bhavi at ubuntu.com
Fri Aug 31 07:11:22 UTC 2012
On Thu, Aug 23, 2012 at 11:58 AM, Bhavani Shankar R <bhavi at ubuntu.com> wrote:
> On Wed, Aug 15, 2012 at 1:11 PM, Andrew Mitchell <ajmitch at ubuntu.com> wrote:
>> On Sun, Jul 15, 2012 at 03:40:30PM -0400, Jonathan Carter (highvoltage) wrote:
>>> Hi!
>>>
>>> On 2012-07-10 20:05, Andrew Starr-Bochicchio wrote:
>>> >Hi,
>>> >
>>> >I've reviewed Ridual
>>> ><https://myapps.developer.ubuntu.com/dev/apps/1201>, and think it is
>>> >ready for vote. I've pushed some minor packaging changes to:
>>> >lp:~andrewsomething/ubuntu-app-reviews/ridual With these changes it
>>> >is lintian clean except for the file installed to opt/ warning and
>>> >not
>>> >closing an ITP bug. It builds in a clean precise chroot. I've
>>> >installed it and gave it a quick test drive with no major issue. It
>>> >is nearly arb-lint clean. It triggers the "might be to large"
>>> >warning.
>>> >I'll let the board decide if it is really too large or not.
>>> >
>>> >W: This app might be too big to be reviewed by the ARB. It has 56
>>> >source
>>> > files and 3349 lines of code. This might serve as reply to the app
>>> > submitter: We are sorry to inform you that this app is outside
>>> >the scope
>>> > of the App Review Board. Our focus is on lightweight apps. We are
>>> > generally looking for the kind of apps which could be reviewed for
>>> > functionality and security in about an hour reading through the
>>> >code.
>>> > https://wiki.ubuntu.com/UbuntuDevelopment/NewPackages might
>>> >suit you
>>> > better.
>>>
>>> Indeed, it's pretty big. Is there a tool that can scan through code
>>> and give some warnings if something looks potentially malicious or
>>> risky?
>>>
>>> Everything else seem fine though. +1
>>>
>>> -Jonathan
>>
>> Seems OK, +1
>>
>
> Seems fine here too +1 from me
>
Switched to 3.0 (native) to build. Uploaded to staging PPA. Will
upload to extras once it builds there
Regards
--
Bhavani Shankar
Ubuntu Developer | www.ubuntu.com
https://launchpad.net/~bhavi
More information about the App-review-board
mailing list