[Vote] F5 Notifier

Bhavani Shankar R bhavi at ubuntu.com
Tue Aug 28 05:42:28 UTC 2012


On Tue, Aug 28, 2012 at 5:35 AM, George <georgeyk.dev at gmail.com> wrote:
> Hi Bhavani,
>
> 2012/8/27 Bhavani Shankar R <bhavi at ubuntu.com>:
> [..]
>> While checking in the master branch I just saw that /bin/f5notifier
>> was under public domain header whereas d/copyright states that all
>> files are under gpl3+
>>
>
> Thanks to point that out, it's fixed now.
> I did not build another package because I would like to add some
> features before.
>

Thanks George for your quick response.

Package looks neat now except:

- /usr/share/python/runtime.d/ is empty. You might want to remove it
- /usr/share/applications/f5-notifier.desktop should be
/usr/share/applications/extras-f5-notifier.desktop
- Short description can be reworded better I think

+0 until above are fixed

Regards,

-- 
Bhavani Shankar
Ubuntu Developer       |  www.ubuntu.com
https://launchpad.net/~bhavi



More information about the App-review-board mailing list