Review: Snare

[Bhavani Shankar R]

On Thu, Jul 12, 2012 at 11:57 PM, Gregory Bonik <gregory at bonik.org> wrote:
> Hello:
>
> I'm not sure whether I'm supposed to reply to this message, but anyway:
>
> * I don't understand what the note about the downloading of the orig tar
> means. The package has been built cleanly in my ppa
> https://launchpad.net/~gregory-bonik/+archive/snare/

Downloaded from PPA and built fine locally

> * Yes, I forgot to include the copyright header in src/format.h. Should
> I really fix it?

You being the single author of the app d/copyright stating that files
are under gpl 3+ should be fine enough I guess

> * About the lint error: this is rather a bug in arb-lint. I need to
> install the file type associations for my program, so I have to install
> them to standard directory /ust/share/mime. I have added the extras-
> prefix to avoid any name clashes.
>

As per the ARB guidelines here:

https://wiki.ubuntu.com/AppReviewBoard/Review/Guidelines#Packaging

All files should go under /opt except for files like changelog,
copyright, desktop files and scopes and lenses as described above

So it isnt a bug we believe.

+0 until this is fixed

> Thank you,

Nice to get the drums rolling in ubuntu btw :)

> Gregory Bonik.
>
Regards,

On behalf of the Application review board,

-- 
Bhavani Shankar
Ubuntu Developer       |  www.ubuntu.com
https://launchpad.net/~bhavi