[Vote] QTranscribe

Bhavani Shankar R bhavi at ubuntu.com
Mon Aug 27 16:23:52 UTC 2012


On Mon, Aug 27, 2012 at 8:24 PM, Bhavani Shankar R <bhavi at ubuntu.com> wrote:
> On Mon, Jul 16, 2012 at 12:52 AM, Jonathan Carter (highvoltage)
> <jonathan at ubuntu.com> wrote:
>> On 2012-07-10 15:18, Michael Hall wrote:
>>>
>>> I have reviewed this package, and made a few changes to address arb-lint
>>> warnings and also to correct the install path from /opt/qtranscribe to
>>> /opt/extras.ubuntu.com/qtranscribe.  The code with these changes is here:
>>>
>>> https://code.launchpad.net/~mhall119/ubuntu-app-reviews/qtranscribe/
>>
>>
>> I'm giving it a careful and tentative +1, I'm not sure about all the sox
>> stuff that's happening there, but it seems mostly harmless and doesn't seem
>> to poke the system in any weird way I could tell.
>>
>> -Jonathan
>>
>>
>
> Built installed the package, doesnt access any system files so its fine with me.
>
> Few notes:
>
> Had to switch to 3.0(native) to build.
>
> There are a couple of lintian warnings:
>
> W: qtranscribe: description-synopsis-starts-with-article
> W: qtranscribe source: quilt-series-but-no-build-dep
>
> This is straight forward to fix apart from that
>
> -rw-r--r-- root/root       262 2012-08-27 19:46
> ./usr/share/applications/qtranscribe.desktop should be
> /usr/share/applications/extras-qtranscribe.desktop
>
> +0 here.
>

Missed mentioning a small typo in d/copyright

On Debian systems, the complete text of the GNU General
 Public License version 2 can be found in "/usr/share/common-licenses/GPL-3".

version 2 should be version 3 I believe

Regards,

-- 
Bhavani Shankar
Ubuntu Developer       |  www.ubuntu.com
https://launchpad.net/~bhavi



More information about the App-review-board mailing list