[Vote] GTumbler

[Andrew Mitchell]

On Sun, Jul 22, 2012 at 10:59:58PM +0530, Bhavani Shankar R wrote:
> On Sun, Jul 22, 2012 at 10:10 PM, Bhavani Shankar R <bhavi at ubuntu.com> wrote:
> > On Sat, Jul 21, 2012 at 8:47 PM, Michael Hall <mhall119 at ubuntu.com> wrote:
> >> I found the relevant license file at
> >> https://raw.github.com/mfenniak/pyPdf/trunk/LICENSE
> >>
> >> I included that text in the debian/copyright file for those files that
> >> use it.  Rev 28 of my branch.
> >>
> >
> > Hi Michael,
> >
> > Thanks for your work. I just had a look at Rev 28. Most of them looks good
> >
> > A few doubts below
> >
> > - Still the debian/control debhelper compatibility doesn't match debian/compat
> > - Still the XB- tags are present.
> >
> > licensecheck shows the below warnings:
> >
> > gtumbler/gtumbler_lib/pdf/__init__.py: *No copyright* UNKNOWN
> > gtumbler/gtumbler_lib/pdf/xmp.py: *No copyright* UNKNOWN
> > gtumbler/gtumbler_lib/command.py: *No copyright* UNKNOWN
> >
> > A conditional +1 based on my doubts above get cleared
> >
> 
> 
> Fixed in Rev 29
> 
> Thanks to Jonathan for clearing my doubts on licensing
> 
> +1 here
> 

+1

Andrew