[Vote] Koza

[Bhavani Shankar R]

On Tue, Jul 24, 2012 at 9:40 AM, John Vrbanac <john.vrbanac at linux.com> wrote:
> I have reviewed this app. A number of dependencies were needed to make the
> app function. Beyond adding those dependencies, I fixed a few lintian and
> arb-lint issues.
>
> You can find my changes here:
> https://code.launchpad.net/~john.vrbanac/ubuntu-app-reviews/koza
>
> Beyond those changes, I believe this app is ready for a vote.
>

Dear Ravi,

As discussed on IRC, Just took a look at the package from your latest
branch here:

https://code.launchpad.net/~ravirdv/koza/main (dint build and test the
package though)

Few observations:

- Why is the ini file present in Databases/ folder? If its intended
for a different platform, it can be removed I guess
-  The TODO folder was empty when I had a look (if you are intending
to add something there, its worth keeping it orelse can be removed I
guess)
- d/compat file is in a executable script format and ideally shouldnt be.

bhavani at bhavani-spagetti-monster:~/arb/main/debian$ ll
total 28
drwxrwxr-x  2 bhavani bhavani 4096 Aug  6 18:24 ./
drwxrwxr-x 14 bhavani bhavani 4096 Aug  6 18:24 ../
-rw-rw-r--  1 bhavani bhavani  751 Aug  6 18:24 changelog
-rwxrwxr-x  1 bhavani bhavani    2 Aug  6 18:24 compat*
-rw-rw-r--  1 bhavani bhavani  743 Aug  6 18:24 control
-rw-rw-r--  1 bhavani bhavani  384 Aug  6 18:24 copyright
-rwxrwxr-x  1 bhavani bhavani 2258 Aug  6 18:24 rules*

- URL of specification in d/copyright is invalid.

You might want to use

http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

and update to the latest format

Your d/copyright states Nokia as the copyright with some junk characters

Copyright: (C) 2011 Nokia -->

whereas AUTHORS file states

Copyright (C) 2012 Ravi Vagadia <ravirdv at gmail.com>

You might want to have another look at the same.

Stopping review here.

Reserving my vote for now

Regards,





-- 
Bhavani Shankar
Ubuntu Developer       |  www.ubuntu.com
https://launchpad.net/~bhavi